analyzing smart contract cost and efficiency

[Myestery]

@briwylde08

Bounty submission for #609
fix #609

[Myestery]

@briwylde08
This is ready for review

[briwylde08]

Thank you for your contribution! We will review and get back to you. I did allocate three weeks to our reviewers and there's a lot to review so apologies in advance if there are any delays!

[Shaptic]

Hi @Myestery! Thank you for your contribution. I think this could use a lot more information on specific techniques and examples for us to consider it for the documentation. While you do touch on some topics, it would be great to have deeper dives on optimization techniques. For example, you could start with a complicated, expensive contract that is unoptimized, then go step by step on various ways on how you can save on instruction or storage costs (e.g. combining steps in a loop, different storage mechanisms, events over storage, etc.). You already do this a bit, but the complex_transfer and simple_transfer are accomplishing fundamentally different things; it'd be better if they accomplished the same thing, but one was much cheaper than the other.

[Myestery]

@Shaptic I have added more context, examples and deep dive to the documentation
Please Re-review

[Myestery]

Hello @briwylde08 @Shaptic
This is ready for merge

[briwylde08]

Sorry for the delay on this one @Myestery! We are working on getting it re-reviewed after your edits. Thank you for your patience! 🙏

[Shaptic]

This is coming along nicely, but there's still some room for improvement for this to be maximally useful for readers. I added a few comments below! Feel free to tag me again when they're resolved.

[Myestery]

Hello @Shaptic
I have modified the docs following your comments.
I took out some parts that were irrelevant too

Ready for your Review

[Myestery]

Hello @Shaptic
This is ready for another review

[Shaptic]

@Myestery this is looking really good at first glance, I'll do a final review first thing tomorrow!

[Shaptic]

Thanks for the reminder - this looks great!! This will be super helpful to people new to optimizing their code for the smart contract environment. Passing it off to @briwylde08 for a final look at grammar etc. + bounty approval.

[briwylde08]

Hi @Myestery! Thank you for the amazing work (and @Shaptic for the thoughtful reviews)! I just made some editorial nit fixes but once that builds we'll get this merged. Let's take the award conversation back over to the corresponding issue!