📝 Refresh six classic guides #723
Draft
+4,049
−819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Page 1 of 6
Page 1 of 6
Page 1 of 6
Page 1 of 6
Page 1 of 6
Page 1 of 6
- Starlight active, details confirmed with SDF at https://discord.com/channels/897514728459468821/907476473739354153/1259478260220301362 - Searching for src on global consensus data packet propogation for relevance in random submisison delay - Need to get hard reference for Protocol 20 one-txn-per-ledger limit
- Use 100px corner rounding
- First time working with this in mdx, pretty nice
Status diction in determinant per stellar/stellar-protocol#1504
|
I'm removing the maker/taker diction since it doesn't apply to the DEX. Some of this got added to contextualize Stellar's functions in terms more akin to traditional markets. But these concepts are both outdated and likely unknown for most new readers—and hopefully we can keep it like that. 💡 |
- By the time this pull merges, the volume/trade approx should hit. - Fixed missing API doc structure MethodTable explainer. - Added Lumenauts video to SCP explainer for accessability.
Effectively all protocol 18 coverage references AMMs because AMMs are generally the more common industry term. While I appreciate that exact diction can be alluring (https://github.com/orgs/WhyDRS/discussions/21), might we scope the introductory page at least to explain rather than confuse readers?
For diction in _Id_, _see also_ R282 at JFWooten4/free-markets@dba9447#r149283300
And simplify the go newTxBuilder preconditions
Gives defereance to full disaply decimals rather than two-digit truncation. As an aside, are there any reputable anchors using display_digitals in their tomls?
Addresses the logic combination and Go documentation. Since we're using it to build an obj to add ops to, signing should stay as is.
I've been digging through the commit history to uncover the origins of some of the JS nesting before stellar#214... I'm updating them to be a little more responsive, readable, and reusable with async waits
I was messing around with `prettier-plugin-sh` and figured the note could be more localized in case we add tabWidths or such later on here (albeit you can locally inspect the upstream import for equivalent affect)
It could be prudent to globalize the accounts so that we can walk through the other limit order examples
|
ddd80c6 overrides 32455bb in deference to |
No known existing community opinions or best practices on the java syntax per https://discord.com/channels/897514728459468821/966788672164855829/1314630372042084534 in re stellar#1044. I know some of the existing pages have been loosely casted, but there seem to be a lot of new users complaining about Docs examples not compiling or running locally given test data.
Most of the present code exemplifications are done or should elsewise be refrenced in text and then relied upon for individual pages to have their own examples.
Some more here dependent on XDR and propogation implementations, which are good for future scopes per https://discord.com/channels/897514728459468821/907476473739354153/1273021348628664433
Relatively scope limited per https://github.com/JFWooten4/JFWooten4/blob/main/decisions/core-723-fn.md
Sort of like how this binds the AttriubteTable to its own scope, especially since it has the same background color.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solving #338 🤝