Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add on-stellar asset for receiving client. #1149

Merged
merged 2 commits into from
Mar 16, 2022
Merged

Conversation

lijamie98
Copy link
Contributor

In the following scenario, the receiving client may receive on-stellar asset.

Sending client --off-stellar --> Sending Anchor
Sending Anchor --on-stellar --> Receiving Anchor
Receiving Anchor--on-stellar --> Receiving Client

In this use case, the sending customer does not have a Stellar account and Receiving Client has a Stellar account. We should add on-stellar asset to the receiving client.

@lijamie98 lijamie98 requested review from leighmcculloch and removed request for accordeiro March 16, 2022 20:28
Copy link
Contributor

@JakeUrban JakeUrban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably need to provide some more examples that demonstrate when the recipient would receive funds on-chain, but we can add those when we have a concrete use case.

Copy link
Contributor

@JakeUrban JakeUrban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh sorry, can you add this PR to the changelog at the bottom?

@lijamie98
Copy link
Contributor Author

Oh sorry, can you add this PR to the changelog at the bottom?

Added to the changelog at the bottom.

@lijamie98 lijamie98 merged commit 7fec4a4 into master Mar 16, 2022
marcelosalloum added a commit to stellar/stellar-anchor-tests that referenced this pull request May 26, 2022
@MonsieurNicolas MonsieurNicolas deleted the modify-sep31-on-stellar branch October 30, 2024 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants