Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the state diagram of a SEP-31 transaction. #1164

Merged
merged 1 commit into from
Apr 4, 2022
Merged

Conversation

lijamie98
Copy link
Contributor

No description provided.

Copy link
Contributor

@JakeUrban JakeUrban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome addition to the specification 👏

Using a PNG is fine for now, but I think it would be best if we ultimately used a mermaid state diagram instead. This would allow us to edit the rendered image using standard syntax directly in this document, similar to our sequence diagram.

@lijamie98 lijamie98 merged commit f96b3c2 into master Apr 4, 2022
@lijamie98
Copy link
Contributor Author

@JakeUrban Great suggestion. I did not know that mermaid supports state diagram. I will modify.

@JakeUrban JakeUrban deleted the add-state-diagram branch April 4, 2022 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants