SEP-31: deprecate per-transaction fields #1387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR deprecates and makes optional the
fieldsobject in theGET /inforesponse, thePOST /transactionsrequests, and thePATCH /transactions/:idrequests. It also deprecates the use of thepending_transaction_info_updatesstatus, since this was only used to request per-transaction fields.To our knowledge this object is not used, and was originally added to account for the possibility of non-standard per-transaction fields. However, supporting the use of non-standard fields in our tools & services meant to make implementing SEP-31 easier is difficult, and given the lack of usage in the ecosystem, it makes sense to deprecate the object and encourage the use of standard SEP-9 fields.