Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update overlay xdr #94

Merged
merged 2 commits into from
May 19, 2023
Merged

update overlay xdr #94

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4b72fa2
update overlay xdr
marta-lokhova May 19, 2023
6deca74
Add comment
marta-lokhova May 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 18 additions & 11 deletions Stellar-overlay.x
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,12 @@ struct SendMore
uint32 numMessages;
};

struct SendMoreExtended
{
uint32 numMessages;
uint32 numBytes;
};

struct AuthCert
{
Curve25519Public pubkey;
Expand All @@ -47,16 +53,14 @@ struct Hello
uint256 nonce;
};


// During the roll-out phrase, pull mode will be optional.
// During the roll-out phrase, nodes can disable flow control in bytes.
// Therefore, we need a way to communicate with other nodes
// that we want/don't want pull mode.
// However, the goal is for everyone to enable it by default,
// so we don't want to introduce a new member variable.
// For now, we'll use the `flags` field (originally named
// `unused`) in `Auth`.
// 100 is just a number that is not 0.
const AUTH_MSG_FLAG_PULL_MODE_REQUESTED = 100;
// that we want/don't want flow control in bytes.
// We use the `flags` field in the Auth message with a special value
// set to communicate this. Note that AUTH_MSG_FLAG_FLOW_CONTROL_BYTES_REQUESTED != 0
// AND AUTH_MSG_FLAG_FLOW_CONTROL_BYTES_REQUESTED != 100 (as previously
// that value was used for other purposes).
const AUTH_MSG_FLAG_FLOW_CONTROL_BYTES_REQUESTED = 200;

struct Auth
{
Expand All @@ -83,7 +87,7 @@ struct PeerAddress
uint32 numFailures;
};

// Next ID: 18
// Next ID: 21
enum MessageType
{
ERROR_MSG = 0,
Expand Down Expand Up @@ -112,6 +116,8 @@ enum MessageType
SURVEY_RESPONSE = 15,

SEND_MORE = 16,
SEND_MORE_EXTENDED = 20,

FLOOD_ADVERT = 18,
FLOOD_DEMAND = 19
};
Expand Down Expand Up @@ -274,7 +280,8 @@ case GET_SCP_STATE:
uint32 getSCPLedgerSeq; // ledger seq requested ; if 0, requests the latest
case SEND_MORE:
SendMore sendMoreMessage;

case SEND_MORE_EXTENDED:
SendMoreExtended sendMoreExtendedMessage;
// Pull mode
case FLOOD_ADVERT:
FloodAdvert floodAdvert;
Expand Down