-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the slic dump
command to create dump.sql
#183
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The most likely use case is one of a plugin developer "getting" a new version of WordPress together with slic
and having to update the file dumps.
For that reason I would make the WordPress version update optional, and the file required.
I think the command should be called dump-update
or something along the line of suggesting that there is an update of the dump involved.
Furthermore, to stick with slic
style of input, I would remove the --
options and decide upon the order of arguments.
E.g. slic dump-update <file> [<wp_version>]
slic dump-update tests/_data/dump.sql
slic dump-update tests/_data/dump.sql 6.4.3
Lastly, I understand and appreciate the --yes
package-managerism, but the operation is easily reversible with a git checkout
(dumps are under version control) and I would just run the update, without confirmation.
975250c
to
6d30997
Compare
Adds the
slic dump
command based on my shell script which performs the same functionality, essentially creating a raw dump.sql for acceptance tests.I'm not tied to any specific command names or descriptions, so let me know if you need changes.
Help Screen: