Fail on not utilizing NoEcho for Password in AWS::DMS::Endpoint #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
reviewed
Jun 22, 2019
|
|
||
| class DMSEndpointPasswordRule < BaseRule | ||
| def rule_text | ||
| 'DMS Endpoint password must be Ref to NoEcho Parameter. ' \ |
There was a problem hiding this comment.
let's flip this rule_text around. DMS endpoint must not be plaintext string of a Ref to a Noecho parm with default. we're letting the dynamic references by or anything else we don't "understand"
ghost
previously requested changes
Jun 22, 2019
jesseadams
approved these changes
Jun 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This takes care of Issue #64
This creates a new Failing rule whenever the Password for DMS Endpoint is set in plaintext either in the resource itself, or as a default from a parameter. If Password for DMS Endpoint is specified, then it needs to be set as a parameter with NoEcho.