Feature/253 remaining password property rules #345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ricationConfiguration
ghost
reviewed
Jan 16, 2020
| def audit_impl(cfn_model) | ||
| managed_blockchain_members = cfn_model.resources_by_type('AWS::ManagedBlockchain::Member') | ||
| violating_managed_blockchains = managed_blockchain_members.select do |member| | ||
| member_config = member.memberConfiguration['MemberFrameworkConfiguration']['MemberFabricConfiguration']['AdminPassword'] |
There was a problem hiding this comment.
which looks like you got, but don't want to dereference the AdminPassword then?
There was a problem hiding this comment.
I've added some logic here to ensure all of these optional properties exist.
ghost
suggested changes
Jan 16, 2020
…before running secure check against value
ghost
approved these changes
Jan 16, 2020
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial for #253
Creates rule for the following resource properties: