Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#394 Cleanup rspec output #395

Merged
1 commit merged into from
Mar 4, 2020

Conversation

pshelby
Copy link
Contributor

@pshelby pshelby commented Mar 3, 2020

Closes #394

Description

Currently when running all rspec tests for cfn_nag, there is close to 300 lines of output written to the screen (see Before section below). This makes it difficult when debugging new rules. By adding error types where needed and suppressing stderr/stdout from cfn_nag_executor calls, this PR will cleanup all erroneous rspec output.

Testing

  1. All rspec tests executed successfully before and after the changes.

Before

rspec_output.txt

After

cfn_nag_dev@caefac1f2dd9:/workspaces/cfn_nag$ bundle exec rspec
Run options: exclude {:end_to_end=>true}
................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................
.........................................................................................................................

Finished in 8.43 seconds (files took 2.78 seconds to load)
697 examples, 0 failures

Coverage report generated for RSpec to /workspaces/cfn_nag/coverage. 2737 / 2826 LOC (96.85%) covered.

@pshelby pshelby requested a review from a user March 3, 2020 14:40
…se_error` where needed and capturing stderr/stdout from cfn_nag_executor.
@pshelby pshelby force-pushed the hotfix/cleanup-rspec-output branch from 06a9f45 to a6bca5a Compare March 3, 2020 15:54
@ghost ghost merged commit 54e119f into stelligent:master Mar 4, 2020
@pshelby pshelby deleted the hotfix/cleanup-rspec-output branch March 9, 2020 17:24
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cleanup rspec output
1 participant