Add LFC threshold tests for DESeq2 #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding LFC thresholding for DESeq2
|
@mikelove it seems an example is erroring |
|
I’ll fix this |
|
Ok this latest commit should fix things |
Thanks a lot for your contribution, and welcome to the tidybulk team! ;) |
|
I have some ideas about exploring isoform-level abundance, especially within genes, do you have anything currently for this? |
Nope, you have carte blanche! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hi Stefano,
I've added examples and tests, and I tested locally to make sure that the bulk methods are still working.
I had already added in the ellipses, but I had forgotten one spot which is why it wasn't working, this PR should include all the necessary ellipses for limma and deseq2