Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ui_step for crt-consumer.fx #3256

Merged
merged 1 commit into from
Jul 21, 2024
Merged

Conversation

user18081972
Copy link
Contributor

For crt-consumer.fx, the ui_step was set to 0, for Scanlines bright/dark.
This PR changes it to 0.05 (same as in Retroarch).

Click for boring and obvious explanation as to why UI_Step=0 is bad When ui_step = 0, Changing the values for Scanlines bright/dark through the UI, forces the value of the shader parameter to the minimum (0.5), and makes it impossible to change it to anything else. This forces the user to remove and re-add the shader, and still being unable to change the values for Scanlines bright/dark to the desired value.

Shameless begging: Stenzek please add the Duckstation shader system to PCSX2 🥺

For crt-consumer.fx, the ui_step was set to 0, for Scanlines bright/dark.
This commit changes it to 0.05 (same as in Retroarch).
@stenzek
Copy link
Owner

stenzek commented Jul 21, 2024

Thanks!

Shameless begging: Stenzek please add the Duckstation shader system to PCSX2 🥺

FYI, I'm no longer associated with PCSX2 (haven't properly been since the start of the year), so that won't be happening, sorry.

@stenzek stenzek merged commit a6e34fa into stenzek:master Jul 21, 2024
0 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants