Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For crt-consumer.fx, the ui_step was set to 0, for Scanlines bright/dark.
This PR changes it to 0.05 (same as in Retroarch).
Click for boring and obvious explanation as to why UI_Step=0 is bad
When ui_step = 0, Changing the values for Scanlines bright/dark through the UI, forces the value of the shader parameter to the minimum (0.5), and makes it impossible to change it to anything else. This forces the user to remove and re-add the shader, and still being unable to change the values for Scanlines bright/dark to the desired value.Shameless begging: Stenzek please add the Duckstation shader system to PCSX2 🥺