Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GPU: Add "Force Frame Timings" option #3287

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

spacepaw
Copy link
Contributor

@spacepaw spacepaw commented Sep 2, 2024

Description

I've revamped the "Force NTSC Timings" option to enable users to enforce both NTSC and PAL timings. The option has been renamed to "Force Frame Timings" and I've replaced the toggle with a drop-down menu.

Reason for the PR

Many homebrew PS1 projects rely on Hitmod as their music player. In earlier versions of Hitmod, music doesn’t play at the correct tempo at 60fps. This new option allows NTSC productions to run at 50fps, ensuring proper music playback.

@stenzek
Copy link
Owner

stenzek commented Sep 3, 2024

Thanks! Few minor points WRT localization, I'll sort those out post-merge.

Will probably rename the setting to "Force Video Timing" rather than "Frame", since "Frame" is ambiguous between video and audio.

Also need to merge the disable interlacing and deinterlacing settings to make room for this one, otherwise the 768p'ers will complain. But that's a me problem for later.

@stenzek stenzek merged commit f511877 into stenzek:master Sep 3, 2024
6 checks passed
stenzek pushed a commit that referenced this pull request Sep 18, 2024
stenzek pushed a commit that referenced this pull request Sep 18, 2024
stenzek pushed a commit that referenced this pull request Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants