Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test.yml #364

Closed

Conversation

varunsh-coder
Copy link
Member

No description provided.

Copy link
Contributor

@step-security-bot step-security-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please find StepSecurity AI-CodeWise code comments inline or below.

.github/workflows/test.yml

Please refer to 1 inline comments.

Feedback

We appreciate your feedback in helping us improve the service! To provide feedback, please use emojis on this comment. If you find a comment helpful, give it a 👍. If they aren't useful, kindly express that with a 👎. If you have questions or detailed feedback, please create n GitHub issue in StepSecurity/AI-CodeWise.

@@ -13,6 +13,9 @@ concurrency:
group: ${{ github.workflow }}
jobs:
test:
permissions:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[High]Use if condition to check that checks and pull-requests permissions are granted

The permissions to write checks and pull-requests should be granted only if they are not granted already. Otherwise, the permissions are granted again and the webhook payload shows duplicate entries for the permissions. Add an if statement to check whether the permissions are not already granted.

@codecov-commenter
Copy link

codecov-commenter commented Dec 5, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c0db65e) 60.29% compared to head (c6cc59c) 60.29%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #364   +/-   ##
=======================================
  Coverage   60.29%   60.29%           
=======================================
  Files           3        3           
  Lines         136      136           
  Branches       32       32           
=======================================
  Hits           82       82           
  Misses         49       49           
  Partials        5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants