[sonic_debian_extension] fix packages.json generation and make the bu… #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ild fail when packages.json is not generated Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
volodymyrsamotiy
approved these changes
Jun 29, 2021
nazariig
reviewed
Jun 30, 2021
| @@ -668,6 +668,10 @@ fi | |||
| SONIC_PACKAGE_MANAGER_FOLDER="/var/lib/sonic-package-manager/" | |||
| sudo mkdir -p $FILESYSTEM_ROOT/$SONIC_PACKAGE_MANAGER_FOLDER | |||
| j2 $BUILD_TEMPLATES/packages.json.j2 | sudo tee $FILESYSTEM_ROOT/$SONIC_PACKAGE_MANAGER_FOLDER/packages.json | |||
| if [ "${PIPESTATUS[0]}" != "0" ]; then | |||
There was a problem hiding this comment.
@stepanblyschak have you considered shopt -s pipefail as general solution?
There was a problem hiding this comment.
Actually no, I think it might break other things that do want to hide error?
There was a problem hiding this comment.
@stepanblyschak ok. Then no need to change.
stepanblyschak
pushed a commit
that referenced
this pull request
Jan 24, 2022
457e94d51 [macsec_linux]: Fixbug cannot dump the PN due to type error (#42) f7c073323 Disable P2P module (#41) 7b3b777e2 [ci]: use native arm64 and armhf build pool (#40) d4e91d66c [sonic_operator]: Increase wait timeout (#39) 43611ef88e [sonic_operators]: Add log in sonic operators (#43) Signed-off-by: Ze Gan <ganze718@gmail.com>
stepanblyschak
pushed a commit
that referenced
this pull request
Mar 25, 2022
f00efef Longxiang Lyu Wed Mar 16 09:12:46 2022 +0800 Add a command line option to store logs into a separate file (#41) ff2e67d Longxiang Lyu Tue Mar 15 09:10:59 2022 +0800 Add default port cable type (#39) ebbb4d8 Jing Zhang Mon Mar 14 15:41:11 2022 -0700 Prevent switching MUX to "Unknown" (#36) c779b8f Longxiang Lyu Thu Mar 10 21:35:11 2022 +0800 [nonfunctional] Use LinkProberStateMachineBase (#38) b9fedd0 Longxiang Lyu Wed Mar 9 13:03:58 2022 +0800 [NONFUNCTIONAL] Add LinkProberStateMachineBase (#37) bedd42b Longxiang Lyu Wed Mar 9 10:03:00 2022 +0800 Add .clang-format file to format code (#28) 9fe4fc6 Guohan Lu Thu Mar 3 17:51:43 2022 -0800 [doc]: add lgtm badge in README.md c1249d9 Longxiang Lyu Wed Mar 2 18:05:18 2022 +0800 Enable lgtm (#33) b8514c6 Longxiang Lyu Wed Mar 2 13:34:39 2022 +0800 Collect port cable type to use corresponding state machine (#31) 9b59ef9 Longxiang Lyu Wed Mar 2 07:19:33 2022 +0800 Improve make clean (#32)
stepanblyschak
pushed a commit
that referenced
this pull request
Apr 28, 2022
4a497407c8697a8c531ab999da95936ac1e71c9b (HEAD -> 201911, origin/201911) Fix the LLDP_LOC_CHASSIS not getting populated if no remote neighbors are present (#39) Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
stepanblyschak
pushed a commit
that referenced
this pull request
Jan 30, 2023
Why I did it [FIPS] Upgrade Open-SymCrypt version to 0.6 Improve the SymCrypt performance Support to download the debug packages from storage account in version 0.6. How I did it Upgrade to symcrypt-openssl from version 0.4 to version 0.6 Changes in https://github.com/sonic-net/sonic-fips: 0c29b23 Upgrade the submodules: SymCrypt and SymCrypt-OpenSSL #40 80022f3 Fix the ARM64 build failure 2e76a3d Disable the unsupported tests Other changes will be added as well: 55b8e0a Merge pull request #35 from xumia/change-license 120c1a7 Upgrade SymCrypt and SymCrypt-OpenSSL 2f9c084 Merge pull request #39 from liuh-80/dev/liuh/update-openssh-version a3be6c5 Revert openssh version e02fa1e Update fips version How to verify it
stepanblyschak
pushed a commit
that referenced
this pull request
Feb 1, 2023
Why I did it [FIPS] Upgrade Open-SymCrypt version to 0.6 Improve the SymCrypt performance Support to download the debug packages from storage account in version 0.6. How I did it Upgrade to symcrypt-openssl from version 0.4 to version 0.6 Changes in https://github.com/sonic-net/sonic-fips: 0c29b23 Upgrade the submodules: SymCrypt and SymCrypt-OpenSSL #40 80022f3 Fix the ARM64 build failure 2e76a3d Disable the unsupported tests Other changes will be added as well: 55b8e0a Merge pull request #35 from xumia/change-license 120c1a7 Upgrade SymCrypt and SymCrypt-OpenSSL 2f9c084 Merge pull request #39 from liuh-80/dev/liuh/update-openssh-version a3be6c5 Revert openssh version e02fa1e Update fips version How to verify it
stepanblyschak
pushed a commit
that referenced
this pull request
Jun 30, 2023
…ly (sonic-net#15545) #### Why I did it src/dhcprelay ``` * c36b8e3 - (HEAD -> master, origin/master, origin/HEAD) [actions] Support Semgrep by Github Actions (#39) (7 hours ago) [Mai Bui] ``` #### How I did it #### How to verify it #### Description for the changelog
stepanblyschak
pushed a commit
that referenced
this pull request
Dec 19, 2023
Why I did it Update the submodule to include the following fixes 2b33d76 dhcpv6 per interface counter support 6a6ce24 fix dhcpv6 relay dual tor source interface selection issue c36b8e3 [actions] Support Semgrep by Github Actions (#39) Work item tracking Microsoft ADO (number only): How I did it How to verify it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ild fail when packages.json is not generated
Signed-off-by: Stepan Blyschak stepanb@nvidia.com
Why I did it
After
https://github.com/Azure/sonic-buildimage/pull/7598the packages.json generation is broken. This change fixes it make the whole build fail in case generation failed.How I did it
Fix and check if generation failed.
How to verify it
Build sonic image, verify presence of the file.
Which release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)