[fast-reboot] Fix delaying counters: apply config to running CONFIG_DB #89
+37
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
volodymyrsamotiy
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Delay flag was set to config_db.json, however, now fast reboot uses running config_db DB dump instead of config_db.json, therefore the delay wasn't set to the right place and didn't have any effect.
Otherwise, orchagent is busy for a long time queries objects before sending APPLY_VIEW.
How I did it
Set delay flag to running config_db.
How to verify it
Do fast-reboot, check that delay flag is set, orchagent does not init counters yet, after some time, delay flag is unset.
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)