Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encapsulated support (RTU over TCP) (updated #260) #385

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

v-zhuravlev
Copy link
Contributor

Hello, updated this pull request #260 to 3.1.4 and main branch(as #260 was based on 3.0.3 as far as I see it).

It would be great if encapsulated is supported in the main branch somehow.

Thanks.

@fatkhrus
Copy link

It will be great if encapsulated will be supported in the main branch

@evgkrsk
Copy link

evgkrsk commented Oct 7, 2017

ping?

@strahlc
Copy link

strahlc commented Jan 25, 2018

why is this not merged?
I need this patch 😄

@kiug
Copy link

kiug commented Jan 25, 2018 via email

@bashlakov
Copy link

This patch is very useful when using RS485 over IP converters without installing virtual com-port software, can it be merged in mainline?

@pboettch
Copy link
Contributor

pboettch commented Feb 15, 2018

@v-zhuravlev I think it would help the integration (if Stephane finds the time) if there would a test for this functionality. Having said that, I know that, I wouldn't know how to test as it seems to be only a client-side implementation.

Maybe with the _raw-function somehow.

And documentation for the rtutcp-function is needed as well.

@v-zhuravlev
Copy link
Contributor Author

v-zhuravlev commented Feb 15, 2018 via email

@pboettch
Copy link
Contributor

For the documentation part you can inspire yourself with what's done in modbus_tcp_connect().

For the testing part, ideally we'd also support rtutcp-server here in libmodbus (if that makes sense) then writing tests would be simpler.

@v-zhuravlev
Copy link
Contributor Author

v-zhuravlev commented Feb 15, 2018 via email

@pboettch
Copy link
Contributor

I think it will be included. It's just a question of time.

@myssta
Copy link

myssta commented Aug 30, 2018

Please consider my approach (#445). It contains both server, client, test, documentation code. however I assumed that the slave id must be set and considered. Please comment especially whether the slave id should be considered or not. I assumed RTU considers it so RTU over TCP should do it, too.

v-zhuravlev and others added 4 commits September 24, 2018 17:45
In case resulting value should be negative it is incorrect to use '+' operator to construct it from pieces, because highest bytes will result in negative number after bitwise shift while others will stay positive. Replacing addition with '|' should solve the issue.
@strahlc
Copy link

strahlc commented Sep 4, 2020

any updates on this?

@strahlc
Copy link

strahlc commented Feb 13, 2023

It is so annoying to keep adapting the patches to new versions of this library.
Please merged this MR.

@damago1
Copy link

damago1 commented Apr 1, 2024

It is so annoying to keep adapting the patches to new versions of this library. Please merged this MR.

mee too. Please. RTU over TCP is very simple and widely used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.