Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test the protocol id for 0 #509

Merged
merged 1 commit into from
Oct 3, 2022

Conversation

metapsychologe
Copy link
Contributor

@metapsychologe metapsychologe commented Dec 15, 2019

previously the test would succeed if one byte was non zero. But the whole ID need to be 0.
Closes #507

previous test would fail if one byte was non zero.
@stephane stephane merged commit 014a9fc into stephane:master Oct 3, 2022
@stephane
Copy link
Owner

stephane commented Oct 3, 2022

Oh yes. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modbus TCP Protocol identifier should be 0
2 participants