Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Foods list #12

Merged
merged 11 commits into from
Aug 1, 2023
Merged

Foods list #12

merged 11 commits into from
Aug 1, 2023

Conversation

dev89s
Copy link
Collaborator

@dev89s dev89s commented Aug 1, 2023

In this PR I've done the tasks as followed:

  1. Added Food mode, controller, routing configs, and DB migration file
  2. Added more styling and some fixes to navigation, login activities, and overall app layout
  3. Added CanCanCan for authorization and configured the Controller to show foods that belong to the user
  4. Added food views and some styling and template changes
  5. Added model validations

@dev89s dev89s requested a review from stephenkati August 1, 2023 11:10
stephenkati
stephenkati approved these changes Aug 1, 2023
View reviewed changes
Copy link
Owner

@stephenkati stephenkati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @dev89s

STATUS: APPROVED

Highlights
Model 💯
Controller 💯
Views 💯
styles 💯

There is nothing else to add, proceed to merge

@dev89s dev89s merged commit b2c7367 into dev Aug 1, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephenkati stephenkati stephenkati approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dev89s @stephenkati