Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Food tests #16

Merged
merged 8 commits into from
Aug 2, 2023
Merged

Food tests #16

merged 8 commits into from
Aug 2, 2023

Conversation

dev89s
Copy link
Collaborator

@dev89s dev89s commented Aug 2, 2023

In this PR I've made the following changes & updates to the code:

  1. Added the model tests for the Food entity
  2. Added the request tests for foods_controller & public_recipes_controller
  3. Added the system tests for foods_controller & public_recipes_controller
  4. Updated the views to give a uniform look to the website and also, add authorization checks for specific sections
  5. Checked for N + 1 database query problems and ensured that there is none.

@dev89s dev89s merged commit dc1dc5d into dev Aug 2, 2023
3 checks passed
stephenkati
stephenkati reviewed Aug 2, 2023
View reviewed changes
Copy link
Owner

@stephenkati stephenkati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @dev89s

STATUS: APPROVED

Nothing else to add, proceed to merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephenkati stephenkati stephenkati left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dev89s @stephenkati