[config/main.py] don't start/stop pmon during config reload #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n is triggered by syncd.
stephenxs
changed the title
keboliu
suggested changes
Sep 11, 2019
stepanblyschak
suggested changes
Sep 11, 2019
config/main.py
Outdated
| @@ -295,6 +295,10 @@ def _stop_services(): | |||
| 'hostcfgd', | |||
| ] | |||
|
|
|||
| # on Mellanox platform pmon is stopped by syncd | |||
| if (version_info and version_info.get('asic_type') == 'mellanox'): | |||
There was a problem hiding this comment.
Parenthesis not required here (lets remove to be more python-way consistent).
Also, in which cases bool(version_info) == False ? Let's teat it as undefined platform error, otherwise we hide the problem and keep pmon in the list
There was a problem hiding this comment.
At the beginning of the file lets initialize asic_type like this:
try:
asic_type = version_info['asic_type']
except KeyError, TypeError:
click.abort('undefined ASIC type')
Any subsequent code that uses asic_type knows that it is initialized correctly
config/main.py
Outdated
| @@ -349,6 +353,10 @@ def _restart_services(): | |||
| 'hostcfgd', | |||
| ] | |||
|
|
|||
| # on Mellanox platform pmon is started by syncd | |||
| if (version_info and version_info.get('asic_type') == 'mellanox'): | |||
added 2 commits
September 12, 2019 12:38
move model level initialization to the head of the file add asic_type other code adjusted accordingly
|
Community PR has [Mellanox] Don't start & stop pmon when config reload #671 been created. |
stephenxs
pushed a commit
that referenced
this pull request
Nov 21, 2023
…aidump_by_route_size (sonic-net#2972) * * [saidump] • Saidump for DNX-SAI sonic-net/sonic-buildimage#13561 Solution and modification: To use the redis-db SAVE option to save the snapshot of DB each time and recover later, instead of looping through each entry in the table and saving it. (1) Updated sonic-buildimage/build_debian.sh, to install Python library rdbtools into the host. (2) Updated sonic-buildimage/src/sonic-sairedis/saidump/saidump.cpp, add a new option -r, which updates the rdbtools's output-JSON files' format. (3) Add a new script file: files/scripts/saidump.sh, to do the below steps For each ASIC0, such as ASIC0, #1. Save the Redis data. sudo sonic-db-cli -n asic$1 SAVE > /dev/null #2. Move dump files to /var/run/redisX/ docker exec database$1 sh -c "mv /var/lib/redis/dump.rdb /var/run/redis$1/" #3. Run rdb command to convert the dump files into JSON files sudo python /usr/local/bin/rdb --command json /var/run/redis$1/dump.rdb | sudo tee /var/run/redis$1/dump.json > /dev/null #4. Run saidump -r to update the JSON files' format as same as the saidump before. Then we can get the saidump result in standard output. docker exec syncd$1 sh -c "saidump -r /var/run/redis$1/dump.json" #5. clear sudo rm -f /var/run/redis$1/dump.rdb sudo rm -f /var/run/redis$1/dump.json (4) Update sonic-buildimage/src/sonic-utilities/scripts/generate_dump, replace saidump with saidump.sh * * [saidump] • Saidump for DNX-SAI sonic-net/sonic-buildimage#13561
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Don't start/stop pmon during config reload since pmon is triggered by syncd.
This PR depends on [syncd.sh] stop pmon ahead of syncd in flows except warm reboot #7
- How I did it
For Mellanox platform, remove pmon from the services_to_stop and service_to_start list.
- How to verify it
execute "config reload" and "systemctl restart swss.service" and check whether all dockers start.
- Previous command output (if the output of a command-line utility has changed)
- New command output (if the output of a command-line utility has changed)
-->