Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add french translation contribution #73

Merged
merged 8 commits into from
Jun 17, 2016
Merged

Conversation

rodinux
Copy link
Contributor

@rodinux rodinux commented Jun 16, 2016

A suggestion to help french users. I also explain how I fixed an issue with Datepicker on rails_admin.
Regards

@monkbroc
Copy link
Collaborator

Merci.

Maybe you included the wrong link in the readme? It links to your fork, not to a file with French translations.

@rodinux
Copy link
Contributor Author

rodinux commented Jun 16, 2016

I put this link because I have also to change date formats on rails_admin.fr.yml and fr.yml to resolve an issue with Datepicker (Datepicker don't show selected date properly). So I put these files needed to get the translation in french working.

@monkbroc
Copy link
Collaborator

Your fork currently only has one commit on top of master rodinux@1d20f9d It only has the change to the readme. The rails_admin.fr.yml and fr.yml are missing.

@rodinux
Copy link
Contributor Author

rodinux commented Jun 17, 2016

Hi, I put the file fr into the locales directory and it works, also on my project.
regards

I correct the links for the contributed translations and a suggestion to translate as well the rails-admin.fr.yml to resolve an issue with the DatePicker.
@rodinux
Copy link
Contributor Author

rodinux commented Jun 17, 2016

I explain better why it's a good idea to change also the translation for rails_admin and add a suggestion to do it... No more
regards

@monkbroc
Copy link
Collaborator

I'd like to keep the link to https://github.com/rodinux/rails_admin_import.fr-MX.yml only in the README and not have the rails_admin.fr.yml in the pull request. The link https://github.com/rodinux/rails_admin_import.fr-MX.yml has all that is needed if someone wants to add French translations to rails_admin_import.

I don't have the time or knowledge to maintain all the translations myself so I'd rather just have links to a place where the translation is maintained instead of pulling in the translation into the main repository.

@rodinux
Copy link
Contributor Author

rodinux commented Jun 17, 2016

ok, I delete the file rails_admin_import.fr and change the notifications as you say.

@monkbroc monkbroc merged commit 31df663 into stephskardal:master Jun 17, 2016
@monkbroc
Copy link
Collaborator

C'est bon! Merci encore!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants