-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add french translation contribution #73
Conversation
Merci. Maybe you included the wrong link in the readme? It links to your fork, not to a file with French translations. |
I put this link because I have also to change date formats on rails_admin.fr.yml and fr.yml to resolve an issue with Datepicker (Datepicker don't show selected date properly). So I put these files needed to get the translation in french working. |
Your fork currently only has one commit on top of master rodinux@1d20f9d It only has the change to the readme. The rails_admin.fr.yml and fr.yml are missing. |
…t with the traduction fr.yml to resolve Datepicker issue
Hi, I put the file fr into the locales directory and it works, also on my project. |
I correct the links for the contributed translations and a suggestion to translate as well the rails-admin.fr.yml to resolve an issue with the DatePicker.
I explain better why it's a good idea to change also the translation for rails_admin and add a suggestion to do it... No more |
I'd like to keep the link to https://github.com/rodinux/rails_admin_import.fr-MX.yml only in the README and not have the rails_admin.fr.yml in the pull request. The link https://github.com/rodinux/rails_admin_import.fr-MX.yml has all that is needed if someone wants to add French translations to rails_admin_import. I don't have the time or knowledge to maintain all the translations myself so I'd rather just have links to a place where the translation is maintained instead of pulling in the translation into the main repository. |
ok, I delete the file rails_admin_import.fr and change the notifications as you say. |
C'est bon! Merci encore! |
A suggestion to help french users. I also explain how I fixed an issue with Datepicker on rails_admin.
Regards