Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add pomodoro command #30

Merged
merged 12 commits into from
Apr 19, 2020
Merged

add pomodoro command #30

merged 12 commits into from
Apr 19, 2020

Conversation

jwford
Copy link
Member

@jwford jwford commented Apr 17, 2020 •
edited by BoedJ
Loading

Describe this PR and why it should be merged:
This PR adds a pomodoro command to assist users with productivity. Closes #28.

Status

  • This PR has been tested and complies with this project's ESLint rules
  • This PR adds/modifes a command
    • The examples and helpUsage options have been created/updated accordingly

Semantic Versioning

  • This PR features bug fixes, or only style changes/refactorings, or no code changes
  • This PR adds features for users
  • This PR switches this project to a new a new Discord API library/new Discord.js framework

@jwford jwford added feature request New feature or request semver: minor Constitutes a minor version update command Requires adding/modifying a command semcommit: feat new feature for users labels Apr 17, 2020
@jwford jwford requested a review from BoedJ April 17, 2020 17:23
@jwford jwford self-assigned this Apr 17, 2020
@jwford
Copy link
Member Author

jwford commented Apr 17, 2020

To do

  • helpUsage and extendedHelp
  • general cleanup and refactoring

@jwford jwford marked this pull request as ready for review April 18, 2020 21:56
BoedJ
BoedJ approved these changes Apr 19, 2020
View reviewed changes
Copy link
Contributor

@BoedJ BoedJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could probably be developed further at some point for Extra Fanciness but all of the basics seem to work well

@jwford jwford merged commit dca4f13 into master Apr 19, 2020
@jwford jwford deleted the pomodoro branch April 19, 2020 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BoedJ BoedJ BoedJ approved these changes

Assignees

@jwford jwford

Labels
command Requires adding/modifying a command feature request New feature or request semcommit: feat new feature for users semver: minor Constitutes a minor version update
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pomodoro
2 participants
@jwford @BoedJ