Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patch to showing urls in Exercie 12 fetch url #151

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Patch to showing urls in Exercie 12 fetch url #151

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
39d33a9
added localhost that are expected in solution.
senpl Sep 25, 2018
8e84eda
added localhost in france language
senpl Sep 25, 2018
8abcfad
added localhost in japan language
senpl Sep 25, 2018
a9d505a
upgraded to mark that version that fix issue 146
senpl Sep 25, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions exercises/fetch_json/problem.fr.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ $ npm install q-io --save

## Tâche

Récupérez du JSON depuis `http://localhost:1337/` et passez-le à `console.log`.
Récupérez du JSON depuis localhost:1337 (`http://localhost:1337/`) et passez-le à `console.log`.

Il y a deux petites choses que vous devez savoir :

Expand All @@ -33,4 +33,4 @@ Il y a deux petites choses que vous devez savoir :
Ce défi peut sembler avancé, mais l’implémentation est plutôt simple. Si vous êtes
bloqué-e, jetez un œil à la documentation de `q-io` pour plus d’informations :

https://github.com/kriskowal/q-io
github.com/kriskowal/q-io https://github.com/kriskowal/q-io
4 changes: 2 additions & 2 deletions exercises/fetch_json/problem.ja.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ $ npm install q-io --save

## 課題

*http://localhost:1337* から JSON をフェッチして、`console.log` に出力します。
localhost:1337 (*http://localhost:1337*) から JSON をフェッチして、`console.log` に出力します。
いくつか知っておくべき事がります：

1.`q-io` の `http` モジュールには成功した (ステータス200) HTTP リクエストの内容の Promise を返す `read` メソッドがあります。
Expand All @@ -30,5 +30,5 @@ $ npm install q-io --save
動かない場合は、`q-io` のドキュメントを参照してください：


https://github.com/kriskowal/q-io
github.com/kriskowal/q-io https://github.com/kriskowal/q-io

4 changes: 2 additions & 2 deletions exercises/fetch_json/problem.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ $ npm install q-io --save

## Task

Fetch JSON from *http://localhost:1337* and `console.log` it.
Fetch JSON from localhost:1337 (*http://localhost:1337*) and `console.log` it.

There are several things you will want to know:

Expand All @@ -33,4 +33,4 @@ This challenge is a bit tricky but the implementation is relatively
straightforward. If you get stuck, refer to the `q-io` documentation for
clarification:

https://github.com/kriskowal/q-io
github.com/kriskowal/q-io (https://github.com/kriskowal/q-io)
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "promise-it-wont-hurt",
"version": "1.1.3",
"version": "1.1.4",
"description": "This is a Workshop module for learning about promises in node.js",
"scripts": {
"start": "node ./promise-it-wont-hurt.js",
Expand Down