Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parse wildcard as an empty set of predicates #29

Merged
merged 1 commit into from
Nov 24, 2017
Merged

Parse wildcard as an empty set of predicates #29

merged 1 commit into from
Nov 24, 2017

Conversation

udoprog
Copy link
Contributor

@udoprog udoprog commented Nov 8, 2017

Following dtolnay/semver#150, this changes the parser for VersionReq to parser pure wildcards * as an empty set of predicates and removes WildcardVersion::Major.

Since this is a breaking change, it also bumps the version to 0.8.0.

@udoprog udoprog mentioned this pull request Nov 8, 2017
Closed
@udoprog
Copy link
Contributor Author

udoprog commented Nov 16, 2017

@steveklabnik poke for feedback?

steveklabnik
steveklabnik approved these changes Nov 24, 2017
View reviewed changes
Copy link
Owner

@steveklabnik steveklabnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, thank you!

@steveklabnik steveklabnik merged commit dfe41d5 into steveklabnik:master Nov 24, 2017
@udoprog udoprog mentioned this pull request Nov 24, 2017
Closed
@steveklabnik steveklabnik mentioned this pull request Dec 8, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steveklabnik steveklabnik steveklabnik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@udoprog @steveklabnik