Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ngWig with angular-material #113

Open
kpgarrod opened this issue Apr 21, 2016 · 11 comments
Open

ngWig with angular-material #113

kpgarrod opened this issue Apr 21, 2016 · 11 comments

Comments

@kpgarrod
Copy link

I am using ngWig(v3) with angular 1.5 and angular-material 1.1. It looks and works great, thanks!

There are two issues which may be related so I am writing them together here. Let me know if I need to split them up.

  1. When I include ng-wig inside a form (with or without md-input-container) the editor does not become focused when tabbing through the form.
  2. On a mobile device the keyboard does not appear when focusing on the editor.

Here is a codepen with ng-wig and the same codepen with a textarea

@stevermeister
Copy link
Owner

@kpgarrod
thank you for detailed explanation of the issue!
I think it's not only about angular-material, we will try to solve this issue

@kpgarrod
Copy link
Author

kpgarrod commented May 1, 2016

Thanks! Please let me know if there's anything I can do to help.

On Sun, May 1, 2016 at 2:34 PM Stepan Suvorov notifications@github.com
wrote:

@kpgarrod https://github.com/kpgarrod
thank you for detailed explanation of the issue!
I think it's not only about angular-material, we will try to solve this
issue


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#113 (comment)

Keith Garrod
Phone +356 2156 9774
Mobile +356 9958 6774

@bampakoa
Copy link
Contributor

bampakoa commented May 5, 2016

  1. When I include ng-wig inside a form (with or without md-input-container) the editor does not become focused when tabbing through the form.

IMO, the focus should be initially on the toolbar of the editor, if we want to account for a11y. If you take a look at the demo on the README page, the focus is indeed on the toolbar (try to press some tabs and then the space key on the keyboard), but it is not visible to the eye due to styling.

@kpgarrod
Copy link
Author

I'm not sure if my point 2 slipped through the cracks, but that is really the critical issue for me right now.

"On a mobile device the keyboard does not appear when focusing on the editor."

This makes the app unusable on a mobile device with ng-wig. I would really appreciate some help with this one as I am using ng-wig extensively and the project is ready to go into production.

@stevermeister
Copy link
Owner

@kpgarrod
I've tested it one more time.
created own sandbox for it - http://codepen.io/stevermeister/pen/beGWNe?editors=1010
and it looks really strange - when you just include angular-material to your project it does not work anymore.

have you created an issue on angular-material repo? it would be nice to listen to their thoughts

@kpgarrod
Copy link
Author

kpgarrod commented May 31, 2016

@stevemeister Thanks for the suggestion. I logged an issue at angular-material but it was closed as a duplicate of another issue which suggests using Summernote. Summernote depends on JQuery and twitter-bootstrap, neither of which I want in my project. I have made a comment to that effect there.

@stevermeister
Copy link
Owner

it's definitely not a duplicate. posted a message there

@kpgarrod
Copy link
Author

Thanks. May I suggest that you also post a message in the open issue:
angular/material#8487 ? I'm not sure if anybody
will look at my issue now that it's closed.

On Tue, May 31, 2016 at 9:57 AM Stepan Suvorov notifications@github.com
wrote:

it's definitely not a duplicate. posted a message there


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#113 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/ACDjkYpyxtV5ay1RgkJBP6kQ48it_e_Zks5qG-nRgaJpZM4IMYQX
.

Keith Garrod
Phone +356 2156 9774
Mobile +356 9958 6774

@stevermeister
Copy link
Owner

@kpgarrod
as you see it's an issue of angular-material
angular/material#5937

@kpgarrod
Copy link
Author

Thanks!

On Tue, May 31, 2016 at 10:35 AM Stepan Suvorov notifications@github.com
wrote:

@kpgarrod https://github.com/kpgarrod
as you see it's an issue of angular-material
angular/material#5937 angular/material#5937


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#113 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/ACDjkYX2BsbmN9zi8MPwjjK5Ff_x3Dh9ks5qG_LvgaJpZM4IMYQX
.

Keith Garrod
Phone +356 2156 9774
Mobile +356 9958 6774

@kpgarrod
Copy link
Author

I am still having this problem with angular-material 1.1.0. I have created an issue there: angular/material#9414. This is affecting my production users so any help would be greatly appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants