omit empty chilren or override

steviebps · Sep 9, 2021 · 7d88172 · 7d88172
1 parent 7d7b205
commit 7d88172
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/pkg/chamber.go b/pkg/chamber.go
@@ -12,7 +12,7 @@ type Chamber struct {
 	IsBuildable bool               `json:"isBuildable"`
 	IsApp       bool               `json:"isApp"`
 	Toggles     map[string]*Toggle `json:"toggles"`
-	Children    []*Chamber         `json:"children"`
+	Children    []*Chamber         `json:"children,omitempty"`
 }
 
 // // EncodeWith takes a writer and encodes JSON to that writer
@@ -63,11 +63,11 @@ func (c *Chamber) InheritWith(inherited map[string]*Toggle) {
 
 // TraverseAndBuild will traverse all Chambers while inheriting their parent Toggles and executes a callback on each Chamber node.
 // Traversing will stop if callback returns true.
-func (c *Chamber) TraverseAndBuild(callback func(*Chamber) bool) {
+func (c *Chamber) TraverseAndBuild(callback func(Chamber) bool) {
 
 	// if callback returns true, stop traversing
 	// consumer was only looking to build up to this point
-	if callback(c) {
+	if callback(*c) {
 		return
 	}
 

diff --git a/pkg/toggle.go b/pkg/toggle.go
@@ -14,7 +14,7 @@ type Toggle struct {
 	Name       string      `json:"name"`
 	ToggleType string      `json:"type"`
 	Value      interface{} `json:"value"`
-	Overrides  []*Override `json:"overrides"`
+	Overrides  []*Override `json:"overrides,omitempty"`
 }
 
 type toggleAlias Toggle