134 model and architecture bug #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
federicazanca
added
bug
|
will need rebase after 137 gets in |
alinelena
force-pushed
the
134-model-and-architecture-bug
branch
from
763fa9a
to
efdd1d1
Compare
Co-authored-by: ElliottKasoar <45317199+ElliottKasoar@users.noreply.github.com>
alinelena
force-pushed
the
134-model-and-architecture-bug
branch
from
efdd1d1
to
eed791e
Compare
oerc0122
reviewed
Jun 6, 2024
oerc0122
reviewed
Jun 6, 2024
oerc0122
reviewed
Jun 6, 2024
oerc0122
reviewed
Jun 6, 2024
oerc0122
reviewed
Jun 6, 2024
Co-authored-by: Jacob Wilkins <46597752+oerc0122@users.noreply.github.com>
alinelena
reviewed
Jun 6, 2024
oerc0122
requested changes
Jun 7, 2024
oerc0122
reviewed
Jun 7, 2024
oerc0122
reviewed
Jun 7, 2024
oerc0122
approved these changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #134
I reorganised a little bit the base code for singlepoint, geometry and md to check that at least one between model and architecture is defined and then fixed some default values if one of the two is not defined.
Before this the used default were from janus but we want to have our own.