-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add single point calculations #31
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alinelena
reviewed
Feb 15, 2024
ElliottKasoar
force-pushed
the
add-single-point
branch
from
February 16, 2024 12:02
6377774
to
a2bb272
Compare
ElliottKasoar
force-pushed
the
add-single-point
branch
from
February 16, 2024 13:31
b8f1a35
to
18a1d28
Compare
Current temporary solution to ASE installation is to update the commit once tests start failing, but this may be a problem for publishing etc. if it passes here, but fails when rerun. |
ElliottKasoar
changed the title
Add single point calculations and geometry optimisation
Add single point calculations
Feb 16, 2024
alinelena
reviewed
Feb 16, 2024
alinelena
reviewed
Feb 16, 2024
alinelena
reviewed
Feb 16, 2024
alinelena
previously approved these changes
Feb 16, 2024
ElliottKasoar
force-pushed
the
add-single-point
branch
from
February 16, 2024 16:34
18a1d28
to
059a9c2
Compare
alinelena
reviewed
Feb 16, 2024
alinelena
approved these changes
Feb 16, 2024
oerc0122
reviewed
Feb 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if these will come through.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #30
Initial code to configure calculators and perform single point calculations for energies, forces and stress.
Largely based on code already in lavello, but refactors, fixes various issues to get tests etc. to pass, and adds more general tests.
Now also adds the ability to return forces and stress.
To do:
read
to read a specified slice/all structures, and attach the calculator to each image.Atoms
objects.Note: CI is currently not working due to issues with pulling ASE from GitLab, but all tests pass locally.