Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve error for webpack 5 #169

Merged
merged 1 commit into from
Dec 14, 2021
Merged

Conversation

acarpe
Copy link
Contributor

@acarpe acarpe commented Dec 13, 2021

the error is:
Should not import the named export 'version' (imported as 'version') from
default-exporting module (only default export is available soon)

the error is:Should not import the named export 'version' (imported as 'version') from
default-exporting module (only default export is available soon)
@leastbad
Copy link
Contributor

Hello Antonio!

We have been discussing your PR and while it looks okay, it also seems odd that you're having any issue at all. We're actually going to be moving to a bundler system soon, too. I thought that in advance of changing the codebase, it makes sense to first understand if perhaps we can understand why the current setup is a problem for you. It's possible that we could fix it together in your project.

To paraphrase @marcoroth, ES modules are new-ish, but not so new that Webpack 5 shouldn't support them.

Are you running this with Webpacker 6 beta or something? I can say, for what it's worth, that Webpacker 5.4.3 works perfectly.

@acarpe
Copy link
Contributor Author

acarpe commented Dec 14, 2021

Yes I upgraded my rails app to use webpacker 6.0.0-rc.6

@leastbad leastbad merged commit 5d79422 into stimulusreflex:master Dec 14, 2021
@leastbad
Copy link
Contributor

Thanks Antonio. I'm still fuzzy on why this is necessary, but I hope it helps. 😉

marcoroth pushed a commit that referenced this pull request Jan 21, 2022
the error is:Should not import the named export 'version' (imported as 'version') from
default-exporting module (only default export is available soon)
marcoroth pushed a commit that referenced this pull request Jan 21, 2022
the error is:Should not import the named export 'version' (imported as 'version') from
default-exporting module (only default export is available soon)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants