Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup StimulusReflex controller callbacks #45
Setup StimulusReflex controller callbacks #45
Changes from 1 commit
dfe13b1
f5a6cd7
0245889
2d2a558
6475807
3ebdc3f
defd259
5139b7a
89482cb
7e8321c
ffd2579
10d3c04
21d3f47
fb32ed5
198b393
cdc89f8
682200a
7fe7169
ddbf6d1
fc2e279
8fa15b1
2033b88
be8b88f
1bd4c46
4445f5f
79f1d16
af81b5e
39f5e1a
ba867ae
914f46c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This invokeCallback probably should have a different name because it's useful for all sorts of things that aren't callbacks. Can we call it
send
as a homage to Ruby?Is
send
a valid function name in JS?Probably not super important, but technically we could change the name of the controller parameter to class (or klass) because really this is a cool pattern even if you're working in React. I always like the idea that people reading the code can learn new tricks, and this isn't specifically a Stimulus thing.
Of course, it might just be confusing, too. I'm not hung up either way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right that it's something of a misnomer to name it a callback. I'll take some time to consider whether or not there is a better naming convention we can use.