Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reflex Callback Skips #466

Merged
merged 1 commit into from
Mar 17, 2021
Merged

Reflex Callback Skips #466

merged 1 commit into from
Mar 17, 2021

Conversation

assuntaw
Copy link
Contributor

@assuntaw assuntaw commented Mar 12, 2021 •
edited
Loading

Type of PR (feature, enhancement, bug fix, etc.)

Enhancement

Description

This PR adds methods to skip previously set before_reflex, around_reflex and after_reflex callbacks.

Why should this be added

It would be useful to be able to set application-wide callbacks in ApplicationReflex and choose to omit these for inheriting reflexes on an individual basis.

Checklist

  • My code follows the style guidelines of this project
  • Checks (StandardRB & Prettier-Standard) are passing
  • This is not a documentation update

Please note that the best way to suggest changes or updates to the documentation is to join Discord and leave a note in the #docs channel. Any documentation updates posted as PRs cannot be accepted at this time. ❤️

@assuntaw assuntaw changed the title Add reflex callback skips Reflex Callback Skips Mar 12, 2021
@leastbad
Copy link
Contributor

This looks great, Assunta!

@danbender
Copy link

danbender commented Mar 12, 2021 •
edited
Loading

👏 nice, this is helpful, Assunta. Many thanks.

marcoroth added a commit to marcoroth/stimulus_reflex that referenced this pull request Mar 15, 2021
@marcoroth
add tests for skip_before/around/after_reflex callbacks
0631537 
as introduced in stimulusreflex#466
marcoroth
marcoroth approved these changes Mar 15, 2021
View reviewed changes
Copy link
Member

@marcoroth marcoroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @assuntaw, thanks for this valuable addition!

This looks good from my perspective! 🎉

@marcoroth marcoroth mentioned this pull request Mar 15, 2021
Merged
3 tasks
@leastbad leastbad merged commit 51a40eb into stimulusreflex:master Mar 17, 2021
@marcoroth marcoroth mentioned this pull request Mar 17, 2021
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcoroth marcoroth marcoroth approved these changes

@hopsoft hopsoft hopsoft approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@assuntaw @leastbad @danbender @hopsoft @marcoroth