feature: add check for default url options #480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks great! I'll try to pull it and verify tonight. |
|
Thank you for making this PR! I am so sorry it's taken as long as it has to get merged. Regardless, we really hope this is just the first of many contributions. |
|
Thank you so much! This is definitely the first of many! Such an honour to contribute this tiny PR to such an awesome repo! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of PR
"Feature"
Description
This PR adds a check to to verify if url_options are set for environments.
Fixes #468
Why should this be added
It will warn developers and may prevent recurring questions to maintainers about helpers adding example.com
Checklist