Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cross-tab errors for piggybacked operations #514

Merged

Conversation

julianrubisch
Copy link
Contributor

Bug Fix

Description

Piggybacked operations would throw errors cross-tab in performOperations if operations were empty.

Why should this be added

Reflexes weren't broken, but it removes the odd console error above

Checklist

  • My code follows the style guidelines of this project
  • Checks (StandardRB & Prettier-Standard) are passing
  • This is not a documentation update

Please note that the best way to suggest changes or updates to the documentation is to join Discord and leave a note in the #docs channel. Any documentation updates posted as PRs cannot be accepted at this time. ❤️

@julianrubisch julianrubisch requested a review from leastbad May 31, 2021 10:30
@julianrubisch julianrubisch force-pushed the fix-piggybacked-operations branch from 3b4b9f2 to 88854bb Compare May 31, 2021 10:31
@leastbad
Copy link
Contributor

Good catch!

@leastbad leastbad merged commit a33d1e7 into stimulusreflex:master May 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants