-
-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Specify form selector #527
Specify form selector #527
Conversation
Out of the gate: there are documentation changes in here. Please, please take them out. |
easy, this is going to rebased once #517 lands |
I can't stress enough how poorly GitBook handles non-clean merges. I get super jumpy when I see things creep in... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the general direction of this PR 👍🏼
Essentially, every paragraph in the docs that has at least one changed character gets duplicated 2-3 times, showing a before/after... but it's all just text. You have to scan every page looking for dupes, and fussing to make sure the right version persists. It takes hours. |
0be1049
to
4c39aff
Compare
4c39aff
to
3c123d6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work. Let's wait for #517 to land then get this merged.
Co-authored-by: Marco Roth <marco.roth@intergga.ch>
258121b
to
62eb8fa
Compare
Enhancement
Description
This PR adds the possibility to declare a custom form selector to be used when scooping up form parameters:
Note: This is based on my work on #517, the actual diff is much smaller: 4c39aff
Why should this be added
At the moment I'm building a
WizardReflex
where the actual form is separated from the navigation buttons/tabs, thus form params wouldn't be submitted.Checklist
Please note that the best way to suggest changes or updates to the documentation is to join Discord and leave a note in the #docs channel. Any documentation updates posted as PRs cannot be accepted at this time. ❤️