Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add generator options to skip reflex and stimulus #543

Merged
merged 4 commits into from
Sep 2, 2021
Merged

Add generator options to skip reflex and stimulus #543

merged 4 commits into from
Sep 2, 2021

Conversation

nachiket87
Copy link
Contributor

@nachiket87 nachiket87 commented Aug 31, 2021

Feature

Description

As requested by @julianrubisch in #541. A user might not require a stimulus controller or an application_reflex or both to be created or modified when using the generator. This PR adds four options --skip-stimulus, --skip-reflex, --skip-app-controller and --skip-app-reflex that helps the developer customize the files required.

Fixes #541

Why should this be added

Everyone doesn't need the stimulus controller to be automatically created when using the generator. The added options can potentially save time by adding a simple flag to the generator instead of having to delete files or manually modify unwanted changes made by the generator.

Checklist

  • My code follows the style guidelines of this project
  • Checks (StandardRB & Prettier-Standard) are passing
  • This is not a documentation update

Thank for your the opportunity to contribute again! ❤️

@nachiket87 nachiket87 changed the title feature: add generator options to skip reflex and stimulus Add generator options to skip reflex and stimulus Aug 31, 2021
@julianrubisch
Copy link
Contributor

LGTM and many thanks!

The only question arising is if we should shorten "application" to "app" for less typing?

@nachiket87
Copy link
Contributor Author

@julianrubisch I agree! and done!

@julianrubisch julianrubisch merged commit 7aa3a97 into stimulusreflex:master Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow to skip stages in the generator
2 participants