When searching a controller based off a reflex name, ignore hyphens #558
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of PR (feature, enhancement, bug fix, etc.)
Bug fix
Description
Stimulus controller identifiers are using kebab-case, while Reflex class name are CamelCase, which means if the controller and reflex combo are 2 or more words the controller lookup for client callbacks will fail. When it fails, it usually defaults to the first registered controller (https://github.com/stimulusreflex/stimulus_reflex/blob/master/javascript/controllers.js#L44).
It will then fail to call the callbacks if the first controller registered is a different one.
Why should this be added
It is not farfetched to have more than one controller in the page, and also to have a controller name being more than 1 word. This combo lead to unexpected behaviour like calling the wrong callbacks.
Checklist