Fall back to empty siblings list if no parentNode is present #566
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug Fix
Description
When combining
updates_for
with a page or selector morph, a race condition could occur where SR'selementToXPath
would try to parse a document fragment that's not yet connected to the DOM as part ofupdates_for
's morphing process. Traversing up the tree, such an element would have noparentNode
and thus no siblings.This PR fixes it by falling back to an empty siblings array should that occur.
Checklist