Properly handle incomplete HTML fragments #622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcoroth
reviewed
Jan 10, 2023
|
I smoke-tested it in the browser and it seems to work, indeed! @marcoroth |
marcoroth
reviewed
Jan 10, 2023
|
Thank you @cmer! |
Which was removed in stimulusreflex@cacb898
marcoroth
approved these changes
Jan 10, 2023
marcoroth
added a commit
to marcoroth/stimulus_reflex
that referenced
this pull request
Jan 11, 2023
# Type of PR (feature, enhancement, bug fix, etc.) Bug Fix ## Description Properly handle incomplete HTML fragments that would normally be stripped out by Nokogiri. For example, `<tr><td></td></td>` is invalid by itself because it is not wrapped in a `table` element. This PR detects these instances and handle them gracefully. Fixes # (issue) ## Why should this be added Ability to morph parts of a table is important. ## Checklist - [x] My code follows the style guidelines of this project - [x] Checks (StandardRB & Prettier-Standard) are passing - [x] This is not a documentation update Co-authored-by: Marco Roth <marco.roth@intergga.ch>
|
I noticed that this pull request was created to merge into the I just cherry-picked this commit into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of PR (feature, enhancement, bug fix, etc.)
Bug Fix
Description
Properly handle incomplete HTML fragments that would normally be stripped out by Nokogiri. For example,
<tr><td></td></td>is invalid by itself because it is not wrapped in atableelement. This PR detects these instances and handle them gracefully.Fixes # (issue)
Why should this be added
Ability to morph parts of a table is important.
Checklist
Please note that the best way to suggest changes or updates to the documentation is to join Discord and leave a note in the #docs channel. Any documentation updates posted as PRs cannot be accepted at this time. ❤️