Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Schema configurable #624

Merged
merged 2 commits into from
Jan 15, 2023

Conversation

marcoroth
Copy link
Member

@marcoroth marcoroth commented Jan 15, 2023

Type of PR

Enhancement

Description

This Pull Request enables the StimulusReflex schema to be overridden multiple times. Previously, setting Schema.set(application) more than once wouldn't save the new values.

Resolves #607

Why should this be added

This makes the behavior of Schema.set(application) consistent and lets the developer adjust it multiples times.

Checklist

  • My code follows the style guidelines of this project
  • Checks (StandardRB & Prettier-Standard) are passing
  • This is not a documentation update

So that i t can be overridden multiple times
@marcoroth marcoroth added the enhancement New feature or request label Jan 15, 2023
@marcoroth marcoroth merged commit f25884e into stimulusreflex:master Jan 15, 2023
@marcoroth marcoroth deleted the make-schema-configurable branch January 15, 2023 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor schema.js
1 participant