Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix undefined package_json during Yarn install #676

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

mattboldt
Copy link
Contributor

@mattboldt mattboldt commented Nov 26, 2023

Type of PR

Bug fix

Description

When running rails stimulus_reflex:install on a new Rails app using Yarn & esbuild, the following error is raised:

  --- [yarn] ----
  rails aborted!
  NameError: undefined local variable or method `package_json'
  for #<Rails::Generators::AppGenerator...

Looks like it's a missing update from
#655

Why should this be added

Setup raises errors at the Yarn step

Checklist

  • My code follows the style guidelines of this project
  • Checks (StandardRB & Prettier-Standard) are passing

When running rails stimulus_reflex:install on a new Rails app using
Yarn, the following error is raised:

  --- [yarn] ----
  rails aborted!
  NameError: undefined local variable or method `package_json'
  for #<Rails::Generators::AppGenerator...

Looks like it's a missing update from
stimulusreflex#655
Copy link

netlify bot commented Nov 26, 2023

Deploy Preview for stimulusreflex ready!

Name Link
🔨 Latest commit 34a75d2
🔍 Latest deploy log https://app.netlify.com/sites/stimulusreflex/deploys/6563bfe502b5f80008b868c3
😎 Deploy Preview https://deploy-preview-676--stimulusreflex.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@marcoroth
Copy link
Member

Thank you @mattboldt, let me take a look to make sure this properly works now!

Copy link
Member

@marcoroth marcoroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @mattboldt!

@marcoroth marcoroth merged commit 7d8baa7 into stimulusreflex:main Nov 29, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants