Implement nokogiri-html5-inference to properly support HTML fragment parsing
#696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for stimulusreflex ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
marcoroth
force-pushed
the
nokogiri-tests
branch
from
14aa2df to
e6e8b73
Compare
marcoroth
force-pushed
the
nokogiri-tests
branch
2 times, most recently
from
66725e2 to
44db769
Compare
marcoroth
force-pushed
the
nokogiri-tests
branch
from
44db769 to
b49b864
Compare
This was referenced May 3, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of PR
Enhancement/bug fix
Description
This pull request implements the
nokogiri-html5-inferenceto deal with parsing HTML5 fragments to be used with Selector Morphs.The
nokogiri-html5-inferencegem come about out of the discussions in #652 and sparklemotion/nokogiri#3023.Fixes #652, Resolves #692, Resolves #674
Big thanks to @flavorjones to talking and working this through with me!
Why should this be added
This pull request makes the handling of document fragments for selector morphs more natural/predictable and resolves the last open issues to release the final versions of StimulusReflex 3.5.
Checklist