Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getStyles() does not close keyframes block #200

Closed
cometkim opened this issue Sep 9, 2020 · 1 comment · Fixed by #202
Closed

getStyles() does not close keyframes block #200

cometkim opened this issue Sep 9, 2020 · 1 comment · Fixed by #202
Labels
bug Something isn't working

Comments

@cometkim
Copy link
Contributor

cometkim commented Sep 9, 2020 •
edited
Loading

Bug report

Describe the bug

Using keyframes API could make unpredictable behavior on SSR because of the unclosed block.

To Reproduce

Use keyframes and extract css using getStyles() API

Expected behavior

result of css.getStyles() has valid CSS.

Screenshots

image

image

System information

  • OS: Ubuntu 20.04
  • Browser: Chrome
  • Version of Next.js:
  • Version of Gatsby: 2.24.49 (with gatsby-theme-stitches)
  • Version of Node.js: 14.3.0

Additional context

cometkim/gatsby-theme-stitches#1 is blocked
@peduarte peduarte added the bug Something isn't working label Sep 9, 2020
@peduarte
Copy link
Contributor

peduarte commented Sep 9, 2020

@cometkim Thanks for raising. We'll get to it. PR's welcome if you feel like contributing 🚀

@cometkim cometkim mentioned this issue Sep 9, 2020
Merged
peduarte pushed a commit that referenced this issue Sep 10, 2020
Merge pull request #202 from cometkim/gh-200
f599fa4 
fix: Close keyframe block on getStyles
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Close keyframe block on getStyles cometkim/stitches
2 participants
@peduarte @cometkim