fix: Fix check against Deno #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bebraw Thanks for this <3 While we're still improving our CI workflow and PRs arent running tests. Can you confirm that you can do these succesfully:
Otherwise this PR looks good to me! |
|
@peduarte Yeah, both complete. If possible, I would consider adding Deno to the build matrix of your CI once you set it up. That way we can see how it goes with the compatibility. I'm not sure if that's trivial, though. |
|
@bebraw sounds like a good idea, thanks for that |
peduarte
approved these changes
Sep 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since I know
windowobject exists on Deno and it hasDenoobject within it, I added a check based on that.Of course the question is how to test this effectively. 😄
Closes #199.