Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TS types for variant composition #218

Merged
merged 1 commit into from
Sep 16, 2020
Merged

Conversation

jjenzz
Copy link
Contributor

@jjenzz jjenzz commented Sep 16, 2020

Fixes #217

@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 16, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 683a27f:

Sandbox Source
Stitches CI: Next.js Configuration
Stitches CI: CRA Configuration
stitches-ts-issue (forked) Issue #217

@jjenzz jjenzz marked this pull request as draft September 16, 2020 16:29
@jjenzz jjenzz force-pushed the fix-ts-variant-composition branch from 64a908e to f23e9fc Compare September 16, 2020 16:39
@jjenzz jjenzz force-pushed the fix-ts-variant-composition branch from f23e9fc to 683a27f Compare September 16, 2020 16:41
@jjenzz jjenzz marked this pull request as ready for review September 16, 2020 16:42
@peduarte peduarte merged commit 50e59bd into canary Sep 16, 2020
@peduarte peduarte deleted the fix-ts-variant-composition branch September 16, 2020 16:53
@peduarte
Copy link
Contributor

Awesome. Thanks for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Variants not recognised by Typescript
2 participants