Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused types in css-types.ts #369

Merged
merged 1 commit into from
Feb 15, 2021
Merged

Remove unused types in css-types.ts #369

merged 1 commit into from
Feb 15, 2021

Conversation

yenbekbay
Copy link
Contributor

This PR removes unused CSS property types. Unused types are problematic because they cause type-checking to fail if you have the noUnusedLocals flag enabled in your tsconfig.json.

I also looked at https://github.com/frenic/csstype for reference and these types don't seem to be present there anymore either.

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 8ee39c8:

Sandbox Source
Stitches CI: CRA Configuration
Stitches CI: Next.js Configuration

@peduarte
Copy link
Contributor

Thanks! /cc @hadihallak

@peduarte peduarte requested a review from hadihallak February 15, 2021 15:43
@jonathantneal jonathantneal merged commit 8b0da23 into stitchesjs:canary Feb 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants