-
Notifications
You must be signed in to change notification settings - Fork 254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CSS type for utils overshadowing properties #960
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,62 @@ | ||
| import { createStitches, PropertyValue, CSS } from '../types/index' | ||
|
|
||
| const config = { | ||
| utils: { | ||
| background: (value: boolean | PropertyValue<'background'>) => { | ||
| if (typeof value === 'boolean') { | ||
| return value ? { | ||
| background: 'red' | ||
| } : {} | ||
| } else { | ||
| return { | ||
| background: value | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| } | ||
|
|
||
| const { css, globalCss } = createStitches(config) | ||
|
|
||
| globalCss({ | ||
| html: { | ||
| background: true | ||
| }, | ||
| body: { | ||
| background: 'green' | ||
| }, | ||
| }) | ||
|
|
||
| const Component = css({ | ||
| background: true, | ||
| '> *': { | ||
| background: 'green' | ||
| } | ||
| }) | ||
|
|
||
| Component({ | ||
| background: 'green', | ||
| '> *': { | ||
| background: true | ||
| } | ||
| }) | ||
|
|
||
| css(Component, { | ||
| background: 'green' | ||
| }) | ||
|
|
||
| css(Component, { | ||
| background: true | ||
| }) | ||
|
|
||
| const style: CSS = { | ||
| background: true // expect error | ||
| } | ||
|
|
||
| const style2: CSS<typeof config> = { | ||
| background: true | ||
| } | ||
|
|
||
| const style3: CSS<typeof config> = { | ||
| background: 'green' | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,81 @@ | ||
| import { createStitches, PropertyValue, CSS } from '../types/index' | ||
|
|
||
| const config = { | ||
| utils: { | ||
| background: (value: boolean | PropertyValue<'background'>) => { | ||
| if (typeof value === 'boolean') { | ||
| return value ? { | ||
| background: 'red' | ||
| } : {} | ||
| } else { | ||
| return { | ||
| background: value | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| } | ||
|
|
||
| const { css, globalCss, styled } = createStitches(config) | ||
|
|
||
| globalCss({ | ||
| html: { | ||
| background: true | ||
| }, | ||
| body: { | ||
| background: 'green' | ||
| }, | ||
| }) | ||
|
|
||
| const CComponent = css({ | ||
| background: true, | ||
| '> *': { | ||
| background: 'green' | ||
| } | ||
| }) | ||
|
|
||
| CComponent({ | ||
| background: 'green', | ||
| '> *': { | ||
| background: true | ||
| } | ||
| }) | ||
|
|
||
| css(CComponent, { | ||
| background: 'green' | ||
| }) | ||
|
|
||
| css(CComponent, { | ||
| background: true | ||
| }) | ||
|
|
||
| const SComponent = styled('div', { | ||
| background: 'green', | ||
| '> *': { | ||
| background: true | ||
| } | ||
| }) | ||
|
|
||
| void function Test() { | ||
| return ( | ||
| <SComponent css={{ | ||
| background: true, | ||
| '> *': { | ||
| background: 'green' | ||
| } | ||
| }} | ||
| /> | ||
| ) | ||
| } | ||
|
|
||
| const style: CSS = { | ||
| background: true // expect error | ||
| } | ||
|
|
||
| const style2: CSS<typeof config> = { | ||
| background: true | ||
| } | ||
|
|
||
| const style3: CSS<typeof config> = { | ||
| background: 'green' | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I remember that at some point, we explicitly didn’t want utils to override CSS properties, and the types for utils below currently showcase the intention, so this PR doesn’t completely fix the issue.
Now changing this runtime behavior to match the types would be a breaking change to existing users, so I will go ahead and merge this and then fix the type for utils so that it matches what happens at runtime