Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docker rework #1

Merged
merged 5 commits into from
Mar 16, 2021
Merged

Docker rework #1

merged 5 commits into from
Mar 16, 2021

Conversation

adthrasher
Copy link
Member

Update Dockerfile to install all dependencies

@jordan-rash
Copy link
Contributor

I just added an ENTRYPOINT to the Dockerfile

jordan-rash
jordan-rash reviewed Mar 16, 2021
View reviewed changes
Copy link
Contributor

@jordan-rash jordan-rash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think now that it is public, it would be best to remove all the casual comments and place them in issues...thoughts?

Dockerfile Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
@jordan-rash jordan-rash merged commit 74d7d7e into main Mar 16, 2021
@jordan-rash jordan-rash deleted the docker_rework branch March 16, 2021 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jordan-rash jordan-rash jordan-rash left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adthrasher @jordan-rash