Mem allocations (and other miscellaneous improvements) #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This has been sitting in a draft state for a long time, and it's going to be a long time till I can get back to this. IMO we just merge these improvements to clear the queue. This was planned as a much larger PR than it is now. |
adthrasher
approved these changes
Nov 1, 2024
|
|
||
| Int disk_size_gb = ceil((bam_size + gtf_size) * 4) + 10 + modify_disk_size_gb | ||
| Int disk_size_gb = ceil((bam_size + gtf_size) * if pos_sorted then 4 else 1) + 10 + modify_disk_size_gb |
There was a problem hiding this comment.
Is this sufficient to resort and save a name-sorted BAM? Those are typically much larger than the position-sorted BAM.
There was a problem hiding this comment.
There's no resorting of name sorted BAMs. HTSeq requires a name sort for its algorithm, so resorts position sorted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.