docs: example jsons #183
Open
docs: example jsons #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adthrasher
reviewed
Oct 23, 2024
| } | ||
|
|
||
| call util.download as fasta_download { input: | ||
| url = reference_fa_url, | ||
| outfile_name = reference_fa_name, | ||
| md5sum = reference_fa_md5 | ||
| md5sum = reference_fa_md5, | ||
| disk_size_gb = reference_fa_disk_size_gb, |
There was a problem hiding this comment.
I was going to object to the workflow-level parameters, but since disk_size_gb is a required parameter without a default in util.download, I don't think we have much choice.
adthrasher
reviewed
Nov 1, 2024
adthrasher
approved these changes
Nov 1, 2024
|
Going to leave this open until I get a chance to run all of it through miniwdl. Not difficult, but would take some time I don't have at the moment. Will do that sanity check sometime next week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #182